Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/virtual sitemap #119

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Feature/virtual sitemap #119

merged 4 commits into from
Jun 18, 2023

Conversation

boazpoolman
Copy link
Member

What does it do?

Implements a "virtual sitemap".
Prior to this PR the sitemap files were written to the public folder of your Strapi app.
Though this PR introduces a new public API endpoint that will serve a sitemap that is cached in the database.

Why is it needed?

It allows you to use this plugin even if you're not able to write to the file-system.
Also it opens up possibilities for better caching, chunking and

How to test it?

  1. Install PR
  2. Setup the plugin
  3. Add pages
  4. Generate sitemap
  5. Go to /api/sitemap/index.xml (used to be /sitemap/index.xml)

Related issue(s)/PR(s)

#84, #89, #106, #97

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (67763eb) 89.02% compared to head (9135a16) 89.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files           2        2           
  Lines          82       82           
  Branches       32       32           
=======================================
  Hits           73       73           
  Misses          9        9           
Flag Coverage Δ
unit 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@boazpoolman boazpoolman merged commit aa04831 into master Jun 18, 2023
8 checks passed
@boazpoolman boazpoolman deleted the feature/virtual-sitemap branch June 18, 2023 07:53
@marcospassos
Copy link

We are considering discontinuing the use of this library because we have been hit with multiple SEO penalties as a result of the sitemap malfunctioning without our knowledge. However, this new feature seems to be a game-changer. Can you provide an approximate release date for it?

@boazpoolman
Copy link
Member Author

This will be released as a new major version as it introduces breaking changes.
I want to finish the caching implementation (#120) before I do so.
I expect to release this new version (3.0.0) somewhere over the weekend.

About the malfunctioning. Are you refrerring to #101?

@marcospassos
Copy link

No, #97.

@boazpoolman
Copy link
Member Author

boazpoolman commented Jun 19, 2023

Aha. Yes that issue (#97) is resolved with this PR.

Though while we're on the subject, I've left you a comment in #101 on which I would love a reply.
If it turns out to be a major issue I might be able to cramp a fix into the 3.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants