Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow core.js customisation #166

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

ilnytskyi
Copy link
Contributor

Call methods via service

What does it do?

Call methods in core.js via service

Why is it needed?

Allows more flexible customization #60

How to test it?

Try override one of the methods from core.js inside your extensions/sitemap/strapi-server.ts customization as described in #60

Related issue(s)/PR(s)

#60

Call methods via service
@boazpoolman
Copy link
Member

Hi @ilnytskyi
Thanks for this PR, seems like a nice addition.

Could you fix the eslint issue that's happening?
You probably just need to export the getDefaultLanguageLink function and then it can get merged :)

@boazpoolman boazpoolman merged commit 3293516 into pluginpal:master Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants