fix(textarea): on change event broken

pluginsGLPI · Jul 26, 2022 · 9fb70ed · 9fb70ed
1 parent 6685b94
commit 9fb70ed
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/inc/field/fieldsfield.class.php b/inc/field/fieldsfield.class.php
@@ -268,9 +268,10 @@ public function prepareHtmlField($fieldName, $canedit = true, $value = '') {
                   'rows'    => 4,
                   'display' => false,
                ]);
-               $html .= Html::scriptBlock("$(function() {
+               // This JS function intercepts tinyMCE creation then must be executed before end of page load
+               $html .= Html::scriptBlock("
                   pluginFormcreatorInitializeTextarea('$fieldName', '$rand');
-               });");
+               ");
             } else {
                $html.= nl2br($value);
             }

diff --git a/inc/field/textareafield.class.php b/inc/field/textareafield.class.php
@@ -92,6 +92,7 @@ public function getRenderedHtml($domain, $canEdit = true): string {
                   'multiple'      => true,
                   'display'       => false]);
       $html .=  '</div>';
+      // This JS function intercepts tinyMCE creation then must be executed before end of page load
       $html .= Html::scriptBlock("$(function() {
          pluginFormcreatorInitializeTextarea('$fieldName', '$rand');
       });");

diff --git a/js/scripts.js b/js/scripts.js
@@ -1719,10 +1719,21 @@ function pluginFormcreatorInitializeTag(fieldName, rand) {
  * Initialize a textarea field
  */
 function pluginFormcreatorInitializeTextarea(fieldName, rand) {
-   var field = $('[name="' + fieldName + '"]');
-   field.on("change", function(e) {
-      plugin_formcreator.showFields($(field[0].form));
-   });
+   var i = 0;
+   var e;
+   while (e = tinymce.get(i++)) {
+      var field = $('[name="' + fieldName + '"]');
+      var form = field[0].form;
+      if (e.formElement != form) {
+         continue;
+      }
+      // https://stackoverflow.com/a/63342064
+      e.on('input NodeChange', function(e) {
+         tinyMCE.triggerSave();
+         plugin_formcreator.showFields($(form));
+      });
+      return;
+  }
 }
 
 /**