fix(form): bad call to count validators

close: #1594 Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Jan 7, 2020 · e6f4bc8 · e6f4bc8
1 parent fa0c1dd
commit e6f4bc8
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/inc/form.class.php b/inc/form.class.php
@@ -1291,17 +1291,19 @@ class='formcreator_form form_horizontal'>";
                break;
          }
 
-         if ($result->count() > 1) {
-            $validators = [0 => Dropdown::EMPTY_VALUE] + $validators;
-            echo '<h2>' . __('Validation', 'formcreator') . '</h2>';
-            echo '<div class="form-group required liste" id="form-validator">';
-            echo '<label>' . __('Choose a validator', 'formcreator') . ' <span class="red">*</span></label>';
-            Dropdown::showFromArray('formcreator_validator', $validators);
-         }
-         if ($result->count() == 1) {
-            reset($validators);
-            $validatorId = key($validators);
-            echo Html::hidden('formcreator_validator', $validatorId);
+         switch (count($result)) {
+            case 1:
+               reset($validators);
+               $validatorId = key($validators);
+               echo Html::hidden('formcreator_validator', ['value' => $validatorId]);
+               break;
+            case 2:
+               $validators = [0 => Dropdown::EMPTY_VALUE] + $validators;
+               echo '<h2>' . __('Validation', 'formcreator') . '</h2>';
+               echo '<div class="form-group required liste" id="form-validator">';
+               echo '<label>' . __('Choose a validator', 'formcreator') . ' <span class="red">*</span></label>';
+               Dropdown::showFromArray('formcreator_validator', $validators);
+               break;
          }
       }