Fix identical status label in simplified dashboard #3455
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
suggested changes
Feb 9, 2024
inc/formanswer.class.php
Outdated
| @@ -75,7 +75,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM | |||
|
|
|||
| public static function getStatuses() { | |||
| return [ | |||
| self::STATUS_WAITING => __('Waiting', 'formcreator'), | |||
| self::STATUS_WAITING => __('Waiting for approval'), | |||
There was a problem hiding this comment.
In this case, the variable name is ambiguous
Rom1-B
suggested changes
Feb 12, 2024
AdrienClairembault
suggested changes
Feb 12, 2024
Rom1-B
suggested changes
Apr 12, 2024
Comment on lines
+60
to
61
| const STATUS_APPROVAL = 101; | ||
| const STATUS_WAITING = 101; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
Update the STATUS_WAITING label to avoid an identical status label with PENDING. This confusion appears in
My requests for assistance(Simplified dashboard) when GLPI is in French for example.Before :
After :
Checklist
Please check if your PR fulfills the following specifications:
References
Ticket !31528