-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix identical status label in simplified dashboard #3455
base: support/2.13.0
Are you sure you want to change the base?
Fix identical status label in simplified dashboard #3455
Conversation
inc/formanswer.class.php
Outdated
@@ -75,7 +75,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM | |||
|
|||
public static function getStatuses() { | |||
return [ | |||
self::STATUS_WAITING => __('Waiting', 'formcreator'), | |||
self::STATUS_WAITING => __('Waiting for approval'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the variable name is ambiguous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d53bd46
const STATUS_APPROVAL = 101; | ||
const STATUS_WAITING = 101; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
101 is used twice
Changes description
Update the STATUS_WAITING label to avoid an identical status label with PENDING. This confusion appears in
My requests for assistance
(Simplified dashboard) when GLPI is in French for example.Before :
![Capture d’écran du 2024-02-09 14-19-33](https://private-user-images.githubusercontent.com/102067890/303665704-54dd881b-ee6f-4b79-8b87-4883e52dfee9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5MzkzNTgsIm5iZiI6MTcxODkzOTA1OCwicGF0aCI6Ii8xMDIwNjc4OTAvMzAzNjY1NzA0LTU0ZGQ4ODFiLWVlNmYtNGI3OS04Yjg3LTQ4ODNlNTJkZmVlOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyMVQwMzA0MThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NTQ4NjZkODA0Y2I3NzM5YjAzZThhMzA1OTdlZDQ2NzVlNThjYTkxZmM3ZGVjMTRmNTVhMDc0ZDEwM2UzYWY0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ZewZbSUicUTqiWjolmdbLgnGK6NugMrRJ4p0yQG0IxQ)
After :
![Capture d’écran du 2024-02-09 14-20-09](https://private-user-images.githubusercontent.com/102067890/303665904-802fbddc-bb41-47c3-bea7-d9a11efdf45b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5MzkzNTgsIm5iZiI6MTcxODkzOTA1OCwicGF0aCI6Ii8xMDIwNjc4OTAvMzAzNjY1OTA0LTgwMmZiZGRjLWJiNDEtNDdjMy1iZWE3LWQ5YTExZWZkZjQ1Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyMVQwMzA0MThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMTQ2NjFiNDE0NDI3OTgxZDc4YjRlMjlkOTE1OTg2Njg4NzdkZWM2ZGIxNjQ0NTJiZWQ4ZTZjY2Q4ZDU0YzYyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PJEJ19BX4LKDsmqmxQ4tK1dP3Zci6W0BLX9c7m3Xgf8)
Checklist
Please check if your PR fulfills the following specifications:
References
Ticket !31528