Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve device-delete related functions #585

Merged
merged 45 commits into from
Mar 10, 2024
Merged

Improve device-delete related functions #585

merged 45 commits into from
Mar 10, 2024

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 5, 2024

All changes:

  • Improve code in coordinator.py
  • Move automatic device removal to __init__.py, function to util.py and make it work properly so that it functions too when there are more than 1 Plugwise integrations loaded (e.g. Adam plus P1).
  • Add async_remove_config_entry_device() function, this will allow a user to manually delete a removed Plugwise device.

@bouwew bouwew requested a review from a team as a code owner March 5, 2024 19:21
@bouwew bouwew requested a review from CoMPaTech March 5, 2024 19:25
@bouwew bouwew added the enhancement New feature or request label Mar 5, 2024
@bouwew
Copy link
Contributor Author

bouwew commented Mar 9, 2024

OK, ready for review.

Copy link

sonarcloud bot commented Mar 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit 0e5d418 into main Mar 10, 2024
7 checks passed
@bouwew bouwew deleted the add_reload branch March 10, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants