Some minor cleanups #127
Merged
Some minor cleanups #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bouwew
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing the sources I noticed a few unused things that could be cleaned up.
The "domains" key in hacs.json is not supported. I guess it was supported in the past, but it is not documented anymore on https://hacs.xyz/docs/publish/start/#hacsjson
Removed unused constants and util.py which was not used.
The integration still loads fine for me after the changes. I did not run the tests as it is unclear to me how to do so. Usually there is a requirements.txt or requirements_test.txt file to install dependencies and then just run
pytest, but that didn't work and could not find instructions on how to do it.