Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output data for HA Core DUC, restructure into more classes #100

Merged
merged 67 commits into from
Sep 16, 2021
Merged

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Sep 14, 2021

Changes:

  • Change the output to enable the use of the HA Core DUC in plugwise-beta.
  • Change state_class to "total" for interval- and net_cumulative sensors.
  • Remove all remnants of the last_reset-related code (decided also not to keep in combination with state_class = total as the obtained timestamps are quite inaccurate for at least the legacy P1 and the Plugs, it's sometimes minutes off).
  • Restructure: introduce additional classes: SmileComm and SmileConnect

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #100 (6253d31) into main (852ea07) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2248      2235   -13     
=========================================
- Hits          2248      2235   -13     
Impacted Files Coverage Δ
plugwise/constants.py 100.00% <ø> (ø)
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/entities.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)
plugwise/smile.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852ea07...6253d31. Read the comment docs.

@bouwew bouwew merged commit be50323 into main Sep 16, 2021
@bouwew bouwew deleted the output_to_duc branch September 16, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants