USB energy refactor #124
Closed
USB energy refactor #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brefra
commented
Jan 20, 2022
brefra
commented
- Improved timeout message handling based on response messages of USB-stick
- More frequent energy monitoring polling when Stick is idle
- Full rewrite of energy collection code. No dependency to fixed log interval. This should fix
- [BUG] Problems with Plugwise beta plugwise_usb-beta#5
- [BUG] Not all entities of a Circle seem to have valid values yet. plugwise_usb-beta#7
- Added ability to change energy log interval
- Better support for energy production #39
based on NodeResponse or NodeAckResponse messages
To support restructure of StickMessageController class
Don't rely on predicted seq_id but on actual response of stick
- move energy related code to energy.py - make energy not depended to fixed (hour) log interval - allow changing of log interval - make energy collection more flexible to use
Codecov Report
@@ Coverage Diff @@
## main plugwise/python-plugwise#124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2079 2057 -22
=========================================
- Hits 2079 2057 -22
Continue to review full report at Codecov.
|
CoMPaTech
added
enhancement
|
Closing PR as it will eventually be succeeded by the full rewrite of the USB-stick into an async version in async_stick branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.