Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize and rearrange typing-related constants, implement and cleanup. #380

Merged
merged 7 commits into from
Sep 3, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Sep 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #380 (d42ca44) into main (00b9297) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #380   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2685      2684    -1     
=========================================
- Hits          2685      2684    -1     
Files Changed Coverage Δ
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/constants.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bouwew bouwew changed the title Further typing improvements, cleanup Optimize and rearrange typing-related constants, implement and cleanup. Sep 2, 2023
@bouwew bouwew marked this pull request as ready for review September 2, 2023 13:19
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bouwew bouwew merged commit 0ef08d3 into main Sep 3, 2023
17 checks passed
@bouwew bouwew deleted the improve-typing-2 branch September 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants