Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applyQueryBuilder should return Doctrine Query object so pager such a… #5

Closed
wants to merge 5 commits into from

Conversation

danaki
Copy link

@danaki danaki commented Aug 10, 2019

…s KpnPager could make modifications

Fixes #4, refs #1

@pluk77
Copy link
Owner

pluk77 commented Aug 12, 2019

I understand the need for this, but don't think this is the right way of doing it.

Query::getResults() will now return an array or a Query. For pure index queries, it will return an array, while for mixed queries it will return an object.

@pluk77
Copy link
Owner

pluk77 commented Aug 12, 2019

Are you passing the result set to the paginator, or the query object? The original code-base I forked from had an event subscriber for KNP pager, perhaps you can have a look at how that was implemented?

@pluk77
Copy link
Owner

pluk77 commented Sep 14, 2020

Sorry, but I am not going to implement this pull request.

@pluk77 pluk77 closed this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to a member function getId() on array
2 participants