applyQueryBuilder should return Doctrine Query object so pager such a… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s KpnPager could make modifications
|
I understand the need for this, but don't think this is the right way of doing it. Query::getResults() will now return an array or a Query. For pure index queries, it will return an array, while for mixed queries it will return an object. |
|
Are you passing the result set to the paginator, or the query object? The original code-base I forked from had an event subscriber for KNP pager, perhaps you can have a look at how that was implemented? |
|
Sorry, but I am not going to implement this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s KpnPager could make modifications
Fixes #4, refs #1