IE fix: replace reference to js/HTMLDocument with js/Document #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this one? I encountered this same issue with IE9, and am currently using custom dommy version w/ this patch in order to avoid it. |
|
This is fine, as Document is a superclass of HTMLDocument, and still implements all of the methods on document that we care about (querySelector[All], getElementBy{Id | TagName | ClassName}, addEventListener, etc). Thanks for the fix! |
cpetzold
added a commit
that referenced
this pull request
Apr 26, 2013
…ment IE fix: replace reference to js/HTMLDocument with js/Document
djpowell
added a commit
to djpowell/dommy
that referenced
this pull request
Nov 1, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I noticed Dommy breaks in Internet Explorer (versions > 8, I think). This is due to references to HTMLDocument, which results in the following error:
SCRIPT5009: 'HTMLDocument' is undefinedI tried a quick fix and replaced HTMLDocument with Document, which seemed to do the trick. To be honest, however, this might break any number of other things...
This seems to coincide with the pull request by @hsalokor, but just referencing another nonexistant global object. I suppose the "correct" way to fix this would be to check for existence, e.g.
if(typeof HTMLDocument !== 'undefined') { extendPrototype() }. Anyway, as is, it's a pretty nasty bug.