Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA-512 in rust-arkworks #39

Closed
skaunov opened this issue Sep 24, 2023 · 3 comments · Fixed by #42
Closed

SHA-512 in rust-arkworks #39

skaunov opened this issue Sep 24, 2023 · 3 comments · Fixed by #42
Assignees

Comments

@skaunov
Copy link
Collaborator

skaunov commented Sep 24, 2023

I noticed that both c are produced with SHA-256 in <./javascript>. Is it ok to that crate to do it with SHA-512?

@Divide-By-0
Copy link
Member

Oh we are removing sha512 everywhere and only using sha256.

@skaunov
Copy link
Collaborator Author

skaunov commented Sep 24, 2023

What would be corrected test vectors for

pub fn test_against_zk_nullifier_sig_c_and_s() {
in that case?

@Divide-By-0
Copy link
Member

Feel free to just calculate that for i.e. the test anvil sk/pk in the implementation and use that as a test; if the other implementations all give the same result, we can be pretty confident that its calculating correctly!

@skaunov skaunov self-assigned this Sep 24, 2023
skaunov added a commit that referenced this issue Sep 25, 2023
Test values were taken from <./javascript/test/signals.test.ts> line 86
and further.
@skaunov skaunov linked a pull request Sep 25, 2023 that will close this issue
Divide-By-0 added a commit that referenced this issue Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants