perf(styles): do not call path.join twice

improved codecov, shortened test env variable name
plumelo · Mar 13, 2020 · 272bb8b · 272bb8b
1 parent 511ea8d
commit 272bb8b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/rollup.config.js b/rollup.config.js
@@ -17,7 +17,7 @@ export default {
   ],
   plugins: [
     json(),
-    replace({ "process.env.ROLLUP_POSTCSS_TEST": false }),
+    replace({ "process.env.STYLES_TEST": false }),
     resolve({
       preferBuiltins: true,
       extensions: [".ts", ".mjs", ".js", ".json"],

diff --git a/src/loaders/postcss/index.ts b/src/loaders/postcss/index.ts
@@ -112,7 +112,7 @@ const loader: Loader<PostCSSLoaderOptions> = {
         ...postcssModules({
           // Skip hash while testing since CSS content would differ on Windows and Linux
           // due to different line endings.
-          generateScopedName: process.env.ROLLUP_POSTCSS_TEST
+          generateScopedName: process.env.STYLES_TEST
             ? "[name]_[local]"
             : "[name]_[local]__[hash:8]",
           failOnWrongOrder: true,
@@ -195,9 +195,7 @@ const loader: Loader<PostCSSLoaderOptions> = {
         const injectorName = safeId("injector");
         const injectorPath = normalizePath(
           await resolveAsync("./inject-css", {
-            basedir: process.env.ROLLUP_POSTCSS_TEST
-              ? path.join(process.cwd(), "runtime")
-              : path.join(__dirname, "runtime"),
+            basedir: path.join(process.env.STYLES_TEST ? process.cwd() : __dirname, "runtime"),
           }),
         );
         const injectorData =

diff --git a/src/loaders/sass.ts b/src/loaders/sass.ts
@@ -87,7 +87,7 @@ const loader: Loader<SASSLoaderOptions> = {
 
     let fiber: FiberConstructor | undefined;
     // Disable `fibers` for testing, it doesn't work
-    if (sassType == "sass" && !process.env.ROLLUP_POSTCSS_TEST) fiber = loadModule("fibers");
+    if (sassType == "sass" && !process.env.STYLES_TEST) fiber = loadModule("fibers");
 
     return workQueue.add<Payload>(
       async (): Promise<Payload> => {

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -5,7 +5,7 @@ import commonjs from "@rollup/plugin-commonjs";
 import postcss from "../src";
 import { Options } from "../src/types";
 
-process.env.ROLLUP_POSTCSS_TEST = "true";
+process.env.STYLES_TEST = "true";
 
 // Types
 interface WriteData {