Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple unit test for TF 1.14 learning rate schedules #127

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Add simple unit test for TF 1.14 learning rate schedules #127

merged 1 commit into from
Jul 5, 2019

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jul 5, 2019

Fixes #106

@lgeiger lgeiger added this to the v0.4.0 milestone Jul 5, 2019
@lgeiger lgeiger requested a review from arashb July 5, 2019 13:21
arashb
arashb approved these changes Jul 5, 2019
View reviewed changes
larq/optimizers_test.py
),
test_kernels_are_binary=True,
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the default accuracy target (0.75) in _test_optimizer test conservative enough to be proper test for optimizer with this new hyperparameters?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accuracy is above 90% so it should be fine.

@arashb arashb merged commit d730c7c into master Jul 5, 2019
@arashb arashb deleted the test-schedules branch July 5, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arashb arashb arashb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Add test for Bop with tf.keras.optimizer.schedules (TF 1.14+)
2 participants
@lgeiger @arashb