-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reflect): added support for static methods reflection #1023
feat(reflect): added support for static methods reflection #1023
Conversation
Sorry for the delay, finally I can cleanup all the test errors on the First, I see possible breaking change if I apply this. Currently now Plumier scan for I suggest that it's better to use Second, I propose to move the test under
Big thanks for your contribution. |
hey @ktutnik, I'll implement the changes you mentioned. Following the same model, even the support for StaticProperties could be introduced in the future. |
…roperty definition
@pierissimo I investigate this feature deeply and found that its more complex than I thought. Then I decided to collaborate on this, and refactor some of my old code to make it cleaner. I added some abilities, besides the features you added.
I invited you as an outside collaborator, if you have time please help to review my code. |
@ktutnik this is awesome, thank you for the help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Changes included
Add support for the reflection of static methods in a class.
#1022