Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more uncountable words, fixing tests #31

Merged
merged 6 commits into from
Oct 29, 2015

Conversation

jpotts18
Copy link
Contributor

@jpotts18 jpotts18 commented Oct 7, 2015

No description provided.

@blakeembrey
Copy link
Collaborator

I'm not sure about a few of these additions. Some are definitely able to be countable. Thoughts?

@jpotts18
Copy link
Contributor Author

jpotts18 commented Oct 7, 2015

Okay I think the problem here was probably the source that I am using. I think the best thing to do would be to establish some kind of dictionary as your source of truth. When I looked at wikitionary I found different answers. I can go through and update my set of words and compare them to wiktionary.

Wiktionary - Ammo

I'll make the changes to update it to Wiktionary unless you tell me otherwise.

@jpotts18
Copy link
Contributor Author

jpotts18 commented Oct 7, 2015

What about this?

@blakeembrey
Copy link
Collaborator

I don't think there's any major issue with source, but I've just been doing it based on "general consensus" on the internet, a lot of the time the "did you mean" from Google. It's not great though, but the goal was never to build a whole dictionary which would be too large for certain environments.

Even in that chart, there's a few I would consider countable - "currencies", "lands", "rains", "cheeses", "breads", "beauties", "arts", but I hope someone else can jump in here too. I'm ok merging any that aren't on the edge right now.

@jpotts18
Copy link
Contributor Author

I have refined my list. I am pretty confident in these.

@blakeembrey blakeembrey self-assigned this Oct 15, 2015
@blakeembrey
Copy link
Collaborator

Let me review this tonight and we can come up with the list. I don't think there's any need to remove existing rules.

@blakeembrey
Copy link
Collaborator

Ok, so let's leave the original words there and add these (from your commits, looks like the latest is perfect minus removing old ones from before your commit):

  • adulthood
  • ammo
  • athletics
  • cash
  • clothing
  • fun
  • housework
  • literature
  • music
  • research
  • traffic
  • transportation (make sure this one is spelt correctly in the commit)
  • wealth
  • welfare
  • alcohol
  • blood
  • butter
  • chess
  • commerce
  • aid

@blakeembrey
Copy link
Collaborator

@jpotts18 Sorry for the delay, GitHub doesn't actually send a notification when you make changes. LGTM 👍 Thanks.

blakeembrey added a commit that referenced this pull request Oct 29, 2015
adding more uncountable words, fixing tests
@blakeembrey blakeembrey merged commit a27bc1a into plurals:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants