-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding more uncountable words, fixing tests #31
Conversation
I'm not sure about a few of these additions. Some are definitely able to be countable. Thoughts? |
Okay I think the problem here was probably the source that I am using. I think the best thing to do would be to establish some kind of dictionary as your source of truth. When I looked at wikitionary I found different answers. I can go through and update my set of words and compare them to wiktionary. I'll make the changes to update it to Wiktionary unless you tell me otherwise. |
I don't think there's any major issue with source, but I've just been doing it based on "general consensus" on the internet, a lot of the time the "did you mean" from Google. It's not great though, but the goal was never to build a whole dictionary which would be too large for certain environments. Even in that chart, there's a few I would consider countable - "currencies", "lands", "rains", "cheeses", "breads", "beauties", "arts", but I hope someone else can jump in here too. I'm ok merging any that aren't on the edge right now. |
I have refined my list. I am pretty confident in these. |
Let me review this tonight and we can come up with the list. I don't think there's any need to remove existing rules. |
Ok, so let's leave the original words there and add these (from your commits, looks like the latest is perfect minus removing old ones from before your commit):
|
@jpotts18 Sorry for the delay, GitHub doesn't actually send a notification when you make changes. LGTM 👍 Thanks. |
adding more uncountable words, fixing tests
No description provided.