Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency urllib3 to v1.26.18 [security] #1262

Merged
merged 1 commit into from Jan 5, 2024

Conversation

plural-renovate[bot]
Copy link
Contributor

@plural-renovate plural-renovate bot commented Oct 18, 2023

This PR contains the following updates:

Package Update Change
urllib3 (changelog) patch ==1.26.17 -> ==1.26.18

GitHub Vulnerability Alerts

CVE-2023-45803

urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.

From RFC 9110 Section 9.3.1:

A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

Affected usages

Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.

Both of the following conditions must be true to be affected by this vulnerability:

  • If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
  • The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.

Remediation

You can remediate this vulnerability with any of the following steps:

  • Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
  • Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
  • Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.

Release Notes

urllib3/urllib3 (urllib3)

v1.26.18

Compare Source

====================

  • Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@plural-renovate plural-renovate bot added the dependencies Pull requests that update a dependency file label Oct 18, 2023
@plural-renovate plural-renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch 3 times, most recently from 5210408 to 92c1fc2 Compare October 25, 2023 03:36
@plural-renovate plural-renovate bot changed the title chore(deps): update dependency urllib3 to v1.26.18 [security] chore(deps): update dependency urllib3 to v1.26.18 [security] - autoclosed Oct 26, 2023
@plural-renovate plural-renovate bot closed this Oct 26, 2023
@plural-renovate plural-renovate bot deleted the renovate/pypi-urllib3-vulnerability branch October 26, 2023 16:08
@plural-renovate plural-renovate bot changed the title chore(deps): update dependency urllib3 to v1.26.18 [security] - autoclosed chore(deps): update dependency urllib3 to v1.26.18 [security] Oct 26, 2023
@plural-renovate plural-renovate bot reopened this Oct 26, 2023
@plural-renovate plural-renovate bot restored the renovate/pypi-urllib3-vulnerability branch October 26, 2023 21:56
@plural-renovate plural-renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch 6 times, most recently from ca9c561 to a01a8cc Compare November 14, 2023 03:04
@plural-renovate plural-renovate bot changed the title chore(deps): update dependency urllib3 to v1.26.18 [security] chore(deps): update dependency urllib3 to v1.26.18 [security] - autoclosed Nov 27, 2023
@plural-renovate plural-renovate bot closed this Nov 27, 2023
@plural-renovate plural-renovate bot deleted the renovate/pypi-urllib3-vulnerability branch November 27, 2023 17:38
@plural-renovate plural-renovate bot changed the title chore(deps): update dependency urllib3 to v1.26.18 [security] - autoclosed chore(deps): update dependency urllib3 to v1.26.18 [security] Nov 27, 2023
@plural-renovate plural-renovate bot reopened this Nov 27, 2023
@plural-renovate plural-renovate bot restored the renovate/pypi-urllib3-vulnerability branch November 27, 2023 19:46
@plural-renovate plural-renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch 2 times, most recently from de8616c to 6569f41 Compare December 18, 2023 22:22
@plural-renovate plural-renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch 2 times, most recently from 1dbffe6 to 2c87b89 Compare January 5, 2024 01:14
@plural-renovate plural-renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from 2c87b89 to dffacf7 Compare January 5, 2024 01:47
@michaeljguarino michaeljguarino merged commit 560ec30 into master Jan 5, 2024
8 of 11 checks passed
@michaeljguarino michaeljguarino deleted the renovate/pypi-urllib3-vulnerability branch January 5, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant