Skip to content

Commit

Permalink
build(dialog): move theme package to peerDeps
Browse files Browse the repository at this point in the history
in order to ensure state/context can be correctly used to manage theme we need a
single install of the theme package/provider. i'm moving the theme package to be
a peerDependency and it must be install separately

BREAKING CHANGE: @pluralsight/ps-design-system-theme is now a peerDependency and
must be installed separately
  • Loading branch information
danethurber committed Aug 7, 2019
1 parent e9d2554 commit 5596a43
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions packages/dialog/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
"dependencies": {
"@pluralsight/ps-design-system-core": "^4.4.4",
"@pluralsight/ps-design-system-focusmanager": "^2.0.8",
"@pluralsight/ps-design-system-theme": "^3.0.2",
"@pluralsight/ps-design-system-util": "^2.0.5",
"prop-types": "^15.7.2"
},
"peerDependencies": {
"@pluralsight/ps-design-system-normalize": "*",
"@pluralsight/ps-design-system-normalize": "^3.1.4",
"@pluralsight/ps-design-system-theme": "^3.0.2",
"glamor": "^2.20.0",
"react": ">=16.3.0 < 17.0.0"
},
Expand All @@ -35,6 +35,7 @@
"@pluralsight/ps-design-system-button": "^12.0.7",
"@pluralsight/ps-design-system-storybook-addon-center": "^2.0.5",
"@pluralsight/ps-design-system-storybook-addon-theme": "^3.0.0",
"@pluralsight/ps-design-system-text": "^12.0.4"
"@pluralsight/ps-design-system-text": "^12.0.4",
"@pluralsight/ps-design-system-theme": "^3.0.2"
}
}

0 comments on commit 5596a43

Please sign in to comment.