Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Track and plan for changes in polymorphic types #1453

Closed
2 tasks done
jaketrent opened this issue Nov 16, 2020 · 2 comments
Closed
2 tasks done

TS: Track and plan for changes in polymorphic types #1453

jaketrent opened this issue Nov 16, 2020 · 2 comments
Assignees

Comments

@jaketrent
Copy link
Contributor

jaketrent commented Nov 16, 2020

  • Inventory how we handle polymorphism currently, in what components (eg, tagMenu in ActionMenu and renderContent in Scrollable)
  • Record evidence of issues people have with polymorphic types that we have published

Perhaps in the future. In a week? See how teams use the types once they have them.

@EdwardIrby
Copy link
Contributor

Initial findings

@EdwardIrby
Copy link
Contributor

Polymorphic interviews

Recommendation: Stick with multiple props interface pattern over render props approach. Consider adopting Radix polymorphic & primitive in our code base for our own DX. This shouldn't change the existing experience but would allow us to offer an as prop for when a user wanted to change the tag type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants