src: reset process.versions during pre-execution

Reset `process.versions` during pre-execution so that it reflects the versions at run-time rather than when the snapshot was taken. PR-URL: nodejs#53444 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
pluris · Jun 20, 2024 · 2cb3504 · 2cb3504
1 parent 167ef1a
commit 2cb3504
Showing 1 changed file with 37 additions and 27 deletions.
diff --git a/src/node_process_object.cc b/src/node_process_object.cc
@@ -77,34 +77,9 @@ static void GetParentProcessId(Local<Name> property,
   info.GetReturnValue().Set(uv_os_getppid());
 }
 
-MaybeLocal<Object> CreateProcessObject(Realm* realm) {
-  Isolate* isolate = realm->isolate();
-  EscapableHandleScope scope(isolate);
-  Local<Context> context = realm->context();
-
-  Local<FunctionTemplate> process_template = FunctionTemplate::New(isolate);
-  process_template->SetClassName(realm->env()->process_string());
-  Local<Function> process_ctor;
-  Local<Object> process;
-  if (!process_template->GetFunction(context).ToLocal(&process_ctor) ||
-      !process_ctor->NewInstance(context).ToLocal(&process)) {
-    return MaybeLocal<Object>();
-  }
-
-  // process[exit_info_private_symbol]
-  if (process
-          ->SetPrivate(context,
-                       realm->env()->exit_info_private_symbol(),
-                       realm->env()->exit_info().GetJSArray())
-          .IsNothing()) {
-    return {};
-  }
-
-  // process.version
-  READONLY_PROPERTY(
-      process, "version", FIXED_ONE_BYTE_STRING(isolate, NODE_VERSION));
+static void SetVersions(Isolate* isolate, Local<Object> versions) {
+  Local<Context> context = isolate->GetCurrentContext();
 
-  Local<Object> versions = Object::New(isolate);
   // Node.js version is always on the top
   READONLY_STRING_PROPERTY(
       versions, "node", per_process::metadata.versions.node);
@@ -137,8 +112,38 @@ MaybeLocal<Object> CreateProcessObject(Realm* realm) {
             v8::ReadOnly)
         .Check();
   }
+}
+
+MaybeLocal<Object> CreateProcessObject(Realm* realm) {
+  Isolate* isolate = realm->isolate();
+  EscapableHandleScope scope(isolate);
+  Local<Context> context = realm->context();
+
+  Local<FunctionTemplate> process_template = FunctionTemplate::New(isolate);
+  process_template->SetClassName(realm->env()->process_string());
+  Local<Function> process_ctor;
+  Local<Object> process;
+  if (!process_template->GetFunction(context).ToLocal(&process_ctor) ||
+      !process_ctor->NewInstance(context).ToLocal(&process)) {
+    return MaybeLocal<Object>();
+  }
+
+  // process[exit_info_private_symbol]
+  if (process
+          ->SetPrivate(context,
+                       realm->env()->exit_info_private_symbol(),
+                       realm->env()->exit_info().GetJSArray())
+          .IsNothing()) {
+    return {};
+  }
+
+  // process.version
+  READONLY_PROPERTY(
+      process, "version", FIXED_ONE_BYTE_STRING(isolate, NODE_VERSION));
 
   // process.versions
+  Local<Object> versions = Object::New(isolate);
+  SetVersions(isolate, versions);
   READONLY_PROPERTY(process, "versions", versions);
 
   // process.arch
@@ -248,6 +253,11 @@ void PatchProcessObject(const FunctionCallbackInfo<Value>& args) {
                 None,
                 SideEffectType::kHasNoSideEffect)
             .FromJust());
+
+  // process.versions
+  Local<Object> versions = Object::New(isolate);
+  SetVersions(isolate, versions);
+  READONLY_PROPERTY(process, "versions", versions);
 }
 
 void RegisterProcessExternalReferences(ExternalReferenceRegistry* registry) {