Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework user_formulas to support a map of {formula_name}: {formula_source} #163

Closed
lorengordon opened this issue Mar 6, 2017 · 0 comments
Assignees

Comments

@lorengordon
Copy link
Member

lorengordon commented Mar 6, 2017

Right now, effectively, we use formula_termination_strings to determine the formula name (and thus the name of the formula directory in the <salt_srv> root). That gets to be rather hacky. Here's the current config definition:

      formula_termination_strings:
        - -master
        - -latest
      user_formulas:
        #To add other formulas, make sure it is a url to a zipped file as follows:
        #- https://s3.amazonaws.com/salt-formulas/systemprep-formula-master.zip
        #- https://s3.amazonaws.com/salt-formulas/ash-linux-formula-master.zip
        #To "overwrite" submodule formulas, make sure name matches submodule names.

Instead, change the spec for user_formulas to be a map of the formula name and the formula source:

      user_formulas:
        #systemprep-formula: https://s3.amazonaws.com/salt-formulas/systemprep-formula-master.zip
        #ash-linux-formula: https://s3.amazonaws.com/salt-formulas/ash-linux-formula-master.zip

This would deprecate formula_termination_strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant