New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add env command to the command blocks within the cfn lx templates #467
Conversation
]]}, | ||
"env" : | ||
{ | ||
"AWS_DEFAULT_REGION" : { "Ref" : "AWS::Region" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're passing in the region via the env, we can remove it from the aws s3 cp command itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this block is missing in the autoscale edits...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Ensures the following aws envs are available in the appscript shell:
AWS_DEFAULT_REGION
AWS_CA_BUNDLE
REQUESTS_CA_BUNDLE