We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I just discovered that the way "Facebook Comments" are included only works for the entire site and not for every single post.
The file _includes/JB/comments-providers/facebook has to be changed to the following to fix this issue:
_includes/JB/comments-providers/facebook
<div id="fb-root"></div> <script> (function(d, s, id) { var js, fjs = d.getElementsByTagName(s)[0]; if (d.getElementById(id)) return; js = d.createElement(s); js.id = id; js.src = "//connect.facebook.net/en_US/all.js#xfbml=1&appId={{ site.JB.comments.facebook.appid }}"; fjs.parentNode.insertBefore(js, fjs); }(document, 'script', 'facebook-jssdk')); </script> <div class="fb-comments" data-href="{{ site.production_url }}{{ page.url }}" data-num-posts="{{ site.JB.comments.facebook.num_posts }}" data-width="{{ site.JB.comments.facebook.width }}" data-colorscheme="{{ site.JB.comments.facebook.colorscheme }}"></div>
I only changed data-href="{{ site.production_url }}" to data-href="{{ site.production_url }}{{ page.url }}".
data-href="{{ site.production_url }}"
data-href="{{ site.production_url }}{{ page.url }}"
The text was updated successfully, but these errors were encountered:
I just discovered this too. Happy to create a PR to fix this.
Sorry, something went wrong.
Thanks for the info. Can't believe it hasn't been patched yet. Your fix worked great for me.
@FlorianWolters's fix 0f60744 needs to be made in the official repo. I won't add all the formatting changes, just the edit to the existing line ...
// in file: jekyll-bootstrap/_includes/JB/comments-providers/facebook <div class="fb-comments" data-href="{{ site.production_url }}" data-num-posts="...
... to read as follows.
<div class="fb-comments" data-href="{{ site.production_url }}{{ page.url }}" data-num-posts="...
Merge pull request #246 from groundh0g/issue-86
a5554de
Fix for issue #86.
Looks like this is fixed in master. Closing. If you're still having issues, feel free to reopen.
Fix for issue plusjade#86.
827f6d7
groundh0g
No branches or pull requests
Hi,
I just discovered that the way "Facebook Comments" are included only works for the entire site and not for every single post.
The file
_includes/JB/comments-providers/facebook
has to be changed to the following to fix this issue:I only changed
data-href="{{ site.production_url }}"
todata-href="{{ site.production_url }}{{ page.url }}"
.The text was updated successfully, but these errors were encountered: