Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accuracy computation #1

Closed
nboyd opened this issue Nov 19, 2014 · 1 comment
Closed

Accuracy computation #1

nboyd opened this issue Nov 19, 2014 · 1 comment

Comments

@nboyd
Copy link

nboyd commented Nov 19, 2014

Hi,

It seems to me that the line
pred[w,h,int(label[w,h,1,n])+1,n] >= maximum(pred[w, h, 1:channels, n])
contains a potential bug if the prediction scores are, for instance, identically zero.

Note that this is very unlikely to happen after training starts, but it might be nice to fix just in case.

It might be better to compute an argmax of pred and then check that it is equal to the correct label.

-Nick

@pluskid
Copy link
Owner

pluskid commented Nov 20, 2014

@nboyd Thanks for reporting this! For the case of all-zero, or all the predictions are equal or some predictions are equal to the true prediction, then my original code will compute an over optimistic accuracy. However, that happens rarely and that case has intrinsic ambiguity -- now it will depends on how indmax is defined when given an array with non-unique elements. But anyway, I just fixed this. Thanks again for reporting and opening the first issue! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants