-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All day events: Remove Old Events #188
Comments
|
Thanks, I have read the changelog and both those settings are disabled already |
So, is the problem solved, or you still see yesterday's all day event? |
Nope, still the same problem. I had a birthday in my calendar yesterday and today it is still showing with a different background even with past events disabled. I have also found that recurring future events have disappeared. I have a recurring event that happens every day monday to friday in my calendar and it is only showing today. I rolled back to the previous version and the recurring event is showing on all days like it should and the previous days birthday is gone like it should. This update has messed up quite a lot of stuff which is disappointing as this was such a good widget. |
I think that the problem with yesterday's birthday is caused by different time zones:
Could you check and post here:
|
I can confirm that after 12:00pm Australian time the birthday from yesterday has gone. As an example with the birthday the date shows Monday 24th of August to Tuesday the 25th of August so at midnight Tuesday this should be removed. These are birthdays pulled from Facebook. On my phone I have rolled back these are cleared on the newest version on my tablet these are not cleared. Time zone on both is +10 GMT |
PS. These are shown as all day events |
Thank you for information. We are in a process of creating test cases for all such unusual events, so we need help in correct identification of such events. |
Hi thanks for the reply. Sorry I said the data is coming from facebook but both devices are in the +10GMT time zone. I have opened the event in multiple calendars, sunrise, google calendar and no issue Like I said the previous build of the widget handles this perfectly so I believe something is broken in the new release. |
There is no doubt that something is broken in current release. The main question is how to fix one issue and not to create another. What Android version do you have? |
I am running CM12 5.0.2 |
@kaneelias You wrote that the Birthday event is in GMT +10, but you still didn't provide a screenshot that shows that. Please try to create now new birthday ("Birthday 2") and check if it is shown correctly in the Widget. |
Sorry for the confusion I did not say that the even was in +10 gmt. My devices are +10gmt and the birthdays are pulled directly from Facebook |
I have a similar issue. Both past event settings are disabled, however, a multi-day event that started the previous day and continues through today keeps yesterday's date and that calendar entry visible in the widget. In the previous iteration of the widget, yesterday's entry would have disappeared around 8 pm central time, which is what I would prefer over the current outcome. |
I have to agree with @mjt543. Having a two day long event which spans yesterday and today should not show up yesterday when all settings to show previous events are disabled. |
I had an issue like that as well |
Same issue with past all day events here, pain in the backside, hope it gets fixed soon. |
I have the same problem since the last update. |
@kaneelias Using a newly introduced Testing framework, I was able to reproduce problems with multi day events, but I still cannot reproduce your problem with a One day event: Birthday. |
…ill disappear at 00:00 next day (covered by a test case)
@kaneelias In the latest commit filtering of All day events improved. Now yesterday's birthday will disappear at 00:00 local time next day (covered by a test case). |
Sorry, where can I download the new APK to test? |
Same question, where can I download the latest version to test? |
Currently you have to build it from source. |
Calendar widget is published to a beta testing channel. Please join testing at https://play.google.com/apps/testing/com.plusonelabs.calendar |
Thanks I have signed up and will test. Is there are way to check on android if the Beta is installed? |
Google Play requires each version of an application to have unique Version code. Current Beta has version code 29. This Beta may become a release, this is why there are no other differences. |
At the moment you can also check the version number which should read |
Cool that is what I have got. |
My problem with all day events is fixed with the test version, thanks! |
Mine seems to be working as well. |
I dont know if this issue occurs first since this fix in the latest beta. However if i have for intance a event today, with start 08:30 and the event ends 11:00 and i turn on the Phone 08:46 (or hit the refresh button at this time), the event displays starting at the refresh time. |
Not sure if this is a bug in the beta but when I have an active event eg start time is 8:30am till 11:30am. When I check my phone at 9:17 the start time in the widget now shows 9:17 so the current time. I am not a fan of this. Can it be disabled? |
That is already fixed in #199. Please try the latest beta release. |
Closing this as fixed. |
Since the update I now have all day events eg. birthdays from the previous day showing.
I tried adding an exception for "Birthday" in the keywords but that removes future events as well.
How can i get rid of this because it looks ridiculous and is not needed.
Thanks
The text was updated successfully, but these errors were encountered: