Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TmplObj.previewicon a file reference, instead of a file upload field. #203

Closed
jpmschuler opened this issue Aug 20, 2018 · 5 comments
Closed
Assignees

Comments

@jpmschuler
Copy link
Contributor

Currently the field tx_templavoilaplus_tmplobj.previewicon is a file upload field while belayoutand filerefhave the option to reference the file. I'd suggest making all of them alike, as typically all of them would be often in a template folder/extension. And could thus be replaced via a deployment.

I know that this is not urgent and would need a migration wizard as well.
(Nevertheless this would make it one step easier so supply the complete records (and in the end the mapping using an extension).

@opi99 opi99 self-assigned this Aug 20, 2018
@opi99 opi99 added the Feature label Aug 20, 2018
@opi99 opi99 added this to the 7.3.0 milestone Aug 20, 2018
@opi99
Copy link
Collaborator

opi99 commented Oct 16, 2018

While checking your request, tx_templavoilaplus_datastructure.previewicon also have an upload field configuration. Should we transform this same alike?

@jpmschuler
Copy link
Contributor Author

jpmschuler commented Oct 16, 2018

DB-based datastructure is deprecated (or at least not recommended).
Additionally the default is that you can't select the datastructures but only the TObj, so i don't know where this should be displayed except for the admin/integrator during configuration.

So I'd say it isn't worth the effort. But I get it might be easier to have similar configuration everywhere meanwhile.

@opi99
Copy link
Collaborator

opi99 commented Oct 16, 2018

Ok, its not really displayed anywhere.
This will lead to one more field which isn't controllable by sanitizer checks if the content is correct. (As we do not have the "theme extension" path configuration yet.) ... hmmm

@opi99 opi99 modified the milestones: 7.3.0, 7.3.1 Nov 6, 2018
@opi99 opi99 modified the milestones: 7.3.1, 7.3.2 Apr 11, 2019
@opi99
Copy link
Collaborator

opi99 commented Feb 16, 2020

I would like to close this one.

  1. It's a feature for the 7.x line of TV+ which I like to have only in maintenance mode yet
  2. In the 8.x line we will have a complete new way and this isn't needed anymore (hopefully)
    Is it ok for you?

@opi99 opi99 added the Question label Feb 16, 2020
@jpmschuler
Copy link
Contributor Author

Of course that's fine

@opi99 opi99 added wontfix and removed Question labels Feb 18, 2020
@opi99 opi99 removed this from the 7.3.2 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants