Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ upgrade grumphp to 0.16.* and php to mininum 7.2 #9

Merged
merged 1 commit into from
Oct 29, 2019
Merged

⬆️ upgrade grumphp to 0.16.* and php to mininum 7.2 #9

merged 1 commit into from
Oct 29, 2019

Conversation

Kanti
Copy link
Member

@Kanti Kanti commented Oct 29, 2019

No description provided.

@Kanti Kanti requested a review from ChrisB9 October 29, 2019 08:36
@ChrisB9
Copy link

ChrisB9 commented Oct 29, 2019

pluswerk/grumphp-config#28

@Kanti Kanti force-pushed the feature/upgrade-to-grumphp-0-16 branch from f709a7b to 4bb7a0a Compare October 29, 2019 08:58
@Kanti Kanti changed the title ⬆️ upgrade grumphp to 0.16.* and php to mininum 7.0 ⬆️ upgrade grumphp to 0.16.* and php to mininum 7.2 Oct 29, 2019
@Kanti Kanti force-pushed the feature/upgrade-to-grumphp-0-16 branch from 4bb7a0a to 86038de Compare October 29, 2019 09:11
@Kanti Kanti mentioned this pull request Oct 29, 2019
Merged
2 tasks
@Kanti Kanti force-pushed the feature/upgrade-to-grumphp-0-16 branch from 86038de to bd3cfe6 Compare October 29, 2019 10:32
ChrisB9
ChrisB9 previously approved these changes Oct 29, 2019
View reviewed changes
@ChrisB9
Copy link

ChrisB9 commented Oct 29, 2019 

FILE: ...e/travis/build/pluswerk/grumphp-bom-task/src/ExtensionLoader.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | ERROR | [x] Header blocks must be followed by a single blank
   |       |     line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

@Kanti Kanti force-pushed the feature/upgrade-to-grumphp-0-16 branch from bd3cfe6 to fb88c70 Compare October 29, 2019 15:15
@Kanti Kanti merged commit aed5093 into master Oct 29, 2019
@Kanti Kanti deleted the feature/upgrade-to-grumphp-0-16 branch October 29, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisB9 ChrisB9 ChrisB9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kanti @ChrisB9