Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary deep-copy of default RPr degrading performance #263

Open
shelatgauri opened this issue Sep 20, 2017 · 2 comments
Open

Unnecessary deep-copy of default RPr degrading performance #263

shelatgauri opened this issue Sep 20, 2017 · 2 comments

Comments

@shelatgauri
Copy link

When converting a docx to pdf, containg large number of runs, the default RPr is deep-copied using marshalling and unmarshalling multiple times for a single document. To save this time, we can deep-copy the default RPr once and save it in thread local. After each iteration of using RPr element, it can be set to default, using the initial conditions(obtained from default RPr).
link to the pull-request created : #262

@syambrij-pro
Copy link

Updated Conversion.java against commit -
https://github.com/syambrij-pro/docx4j/commit/9a4180a66c3d9e1426bb766439241ef26a48b55a

Created another pull request: #279

@jamding
Copy link

jamding commented May 2, 2022

Screen Shot 2022-05-02 at 3 17 56 PM

Why does substituting the XmlUtils#deepCopy line (source) not suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants