Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions , Subscription plans and Products API #151

Merged
merged 15 commits into from
May 31, 2020
Merged

Subscriptions , Subscription plans and Products API #151

merged 15 commits into from
May 31, 2020

Conversation

rami-dabain
Copy link
Contributor

@rami-dabain rami-dabain commented May 29, 2020

#150
Doc: https://developer.paypal.com/docs/api/catalog-products/v1/
Also refactored small elements in billing like using http.methodGet instead of a hardcoded string "GET"

@rami-dabain rami-dabain changed the title Added product api WIP: Added product api May 29, 2020
@rami-dabain rami-dabain changed the title WIP: Added product api WIP: Subscriptions , Subscription plans and Products API May 29, 2020
@rami-dabain rami-dabain changed the title WIP: Subscriptions , Subscription plans and Products API Subscriptions , Subscription plans and Products API May 29, 2020
Copy link
Collaborator

@roopakv roopakv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I took a quick glance. will review later tonight.

thank you so much rami

Copy link
Collaborator

@roopakv roopakv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once again this is brilliant. thank you so much. few comments

billing.go Outdated Show resolved Hide resolved
billing.go Outdated Show resolved Hide resolved
const.go Outdated Show resolved Hide resolved
products.go Outdated Show resolved Hide resolved
subscription_plan.go Show resolved Hide resolved
Copy link
Collaborator

@roopakv roopakv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this

@roopakv roopakv merged commit d355a65 into plutov:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants