Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from detected_imports #76

Closed
utkonos opened this issue Jan 2, 2020 · 0 comments
Closed

Remove unused code from detected_imports #76

utkonos opened this issue Jan 2, 2020 · 0 comments
Assignees
@utkonos
Labels
enhancement New feature or request
Projects
Bugs 2.1.0
Milestone
2.1

Comments

@utkonos
Copy link
Member

utkonos commented Jan 2, 2020

plyara/plyara/utils.py

Line 75 in 1812718

def detect_imports(rule):

utkonos added a commit that referenced this issue Jan 2, 2020
@utkonos
Fixes #76
1ebb491
@utkonos utkonos self-assigned this Jan 4, 2020
@utkonos utkonos added the enhancement New feature or request label Jan 4, 2020
@utkonos utkonos added this to To Do in Bugs 2.1.0 via automation Jan 4, 2020
@utkonos utkonos added this to the 2.1 milestone Jan 4, 2020
@utkonos utkonos moved this from To Do to In Progress in Bugs 2.1.0 Jan 4, 2020
@utkonos utkonos closed this as completed in 2e8bece Jan 4, 2020
Bugs 2.1.0 automation moved this from In Progress to Done Jan 4, 2020
utkonos added a commit that referenced this issue Feb 25, 2020
@utkonos
Add Back Key/Value Output Option for Meta Section Data (#84)
58ff3af 
* Add option flag for returning meta section as dictionary.

* Remove extraneous import

* Fix bug where whole dict is replaced for each new key

* Make note of not yet supported YARA syntax

* Update date to 2020

* Add unittest for metakv

* Improve tests (#81)

* Fix Codacity warning.
Best practice: https://docs.python.org/3.8/tutorial/modules.html#importing-from-a-package

* Fixes #70

* Revert last change

* Fixes #71

* Remove deprecated methods in preparation for major release.

* Fixes #72

* Fixes #74

* Fixes #75

* Fixes #76

* Fixes #77

* Fixes #78

* Test the actual command line not the script

* Remove unused import

* Add full coverage for generate_logic_hash

* Deprecate rule rebuilding. This function needs to be reworked.
This function does not work on many rulesets and rules.

* Fix docstyle problem

* Actually fix docstring problem.

* Separate parser to function in preparation for unit testing

* Improved path

* Refactor CLI unit test. Fixes #82

* Add unit test for no error

* Fix docstring problem

* Change to multiline assert

* Use hashlib to test CLI output

* Change hash to correct

* Add both possible hashes
This is a workaround for what appears to be a bug in unittest.

* Fixes #83

* Make example executable

* This works from command line.

* Add option flag for returning meta section as dictionary.

* Remove extraneous import

* Fix bug where whole dict is replaced for each new key

* Add unittest for metakv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utkonos utkonos

Labels
enhancement New feature or request
Projects
No open projects
Bugs 2.1.0
  
Done
Milestone
2.1
Development

No branches or pull requests
1 participant
@utkonos