Need to implement __hash__ so entities work with sets

[six8]

No description provided.

[BatsShadow]

This is fixed in #25, right?

[six8]

I suppose so. But we may need to decide on what to __hash__ on. #25 uses id(self) which will use the object's instance ID as a hash. So even if two entity instances have the exact same values, they'll be consider different because they are different instances. If two entity instances with the exact same values should be considered a duplicate, then the __hash__ should take into account the values of the entity.

[BatsShadow]

For some reason, the tests are checking that two entities are equal and their hashes unequal. I have no idea why.

…

On Wed, May 8, 2019 at 12:17 PM Mike Thornton ***@***.***> wrote: I suppose so. But we may need to decide on what to __hash__ on. #25 <#25> uses id(self) which will use the object's instance ID as a hash. So even if two entity instances have the exact same values, they'll be consider different because they are different instances. If two entity instances with the exact same values should be considered a duplicate, then the __hash__ should take into account the values of the entity. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAL2U76Q6QRT7LPCMJQ27KDPUL4KFANCNFSM4BBXBGIQ> .

[six8]

In Python 2 the default __hash__ is basically id(self). So even though the values were equal, the hash is unequal because each instance has different ids. The test was probably just a sanity check to make sure they were different objects.