Feature/use client #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for using mongodb client instead of mongostat cli. For purposes of backwards-compatibility the default is still mongostat but using configuration `useClient` then the mongodb client is used to retrieve the stats. This means you can gather stats from a db instance that is remote from you without installing any Mongodb binaries. Also adds support for environment variables for each of the configuration options.
The correct api is serverStatus under Admin, so switch to correct API. Leverage callback to make sure the provider is initialized before attempting to refresh the metrics.
|
My use case requires accessing a mongodb in another docker container where the local container does not have mongostat or any other related mongodb binary installed. This simply makes it possible to use either/or approach in a consistent manner. |
|
+1 |
|
Thanks for the contribution! Merged to master with few changes:
Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using mongodb client instead of mongostat cli.
For purposes of backwards-compatibility the default is still mongostat
but using configuration
useClientthen the mongodb client is usedto retrieve the stats. This means you can gather stats from a db
instance that is remote from you without installing any Mongodb
binaries.
Also adds support for environment variables for each of the
configuration options.