Properly filtering calling assembly

README.md

@@ -9,7 +9,7 @@ A simple Serilog enricher to add information about the calling method. Loosely b
 
 Performance may be low due the usage of reflection to obtain assembly and method information, as well as the retrieval of the current stacktrace whenever a new log event is added.
 
-To get the actual method that emitted the log event, the stack trace is traversed and the first method that is in a matching assembly is considered the correct one. To configure which assemblies are the correct one, one can either use the configuration method with `assemblyPrefix` or the one that directly accepts a collection of fully qualified assembly names. When passing in a prefix, the assembly that calls the configuration method is recursively analyzed for referenced assemblies and whether they match the prefix. If you e.g. have a solution with projects being called `MySolution.Web`, `MySolution.Domain`, etc., you can limit the included assemblies by passing in the prefix `MySolution`.
+To get the actual method that emitted the log event, the stack trace is traversed and the first method that is in a matching assembly is considered the correct one. To configure which assemblies are the correct one, one can either use the configuration method with `assemblyPrefix` or the one that directly accepts a collection of fully qualified assembly names. When passing in a prefix, the assembly that calls the configuration method is recursively analyzed for referenced assemblies and whether they match the prefix. If you e.g. have a solution with projects being called `MySolution.Web`, `MySolution.Domain`, etc., you can limit the included assemblies by passing in the prefix `MySolution`. Be aware that the assembly from which you configure the logger must also have the correct prefix, otherwise no assemblies will be considered and the enricher won't work.
 
 ## Usage
 

Serilog.Enrichers.CallerInfo/EnricherConfiguration.cs

@@ -57,18 +57,17 @@ private static IEnumerable<string> GetAssemblies(Assembly start, Func<AssemblyNa
         {
             var asmNames = new List<string>();
             var stack = new Stack<Assembly>();
-
             stack.Push(start);
 
             do
             {
                 var asm = stack.Pop();
-
-                if (filter(asm.GetName()))
+                if (!filter(asm.GetName()))
                 {
-                    asmNames.Add(asm.GetName().Name);
+                    continue;
                 }
 
+                asmNames.Add(asm.GetName().Name);
                 foreach (var reference in asm.GetReferencedAssemblies())
                 {
                     if (!filter(reference))