Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unquote quoted atoms to silence Elixir 1.7 warnings #109

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

doughsay
Copy link
Contributor

Elixir 1.7 produces these warnings when compileing:

==> amqp
Compiling 10 files (.ex)
warning: found quoted atom "amqp_params_network" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:44

warning: found quoted atom "amqp_params_network" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:44

warning: found quoted atom "amqp_params_direct" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:45

warning: found quoted atom "amqp_params_direct" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:45

warning: found quoted atom "amqp_adapter_info" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:46

warning: found quoted atom "amqp_adapter_info" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:46

warning: found quoted atom "amqp_msg" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:47

warning: found quoted atom "amqp_msg" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them
  lib/amqp/core.ex:47

Thought I'd clean it up :)

@ono
Copy link
Collaborator

ono commented Sep 12, 2018

Nice one 👍

@ono ono merged commit 84d605b into pma:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants