removing additional folder from android build #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allowing to press Y/y or N/n as input from user
rakesh1988
changed the title
|
sorry. did not read the contributing.md before :) cancelling the PR |
|
Hi there @rakesh1988 and @pmadruga - we noticed an issue in react-native-firebase where @dajaffe had a problem that was only fixed by deleting android/.gradle - and would have been addressed by this PR Is there any interest in getting a delete of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is specific to my version of react native(0.58.4). Output for android was created under ./android/app/build. hence this PR to remove that folder as well.
Also removing .gradle folder from ./android/.gradle
Thanks