Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tasks.js #27

Merged
merged 5 commits into from
Nov 25, 2019
Merged

Update tasks.js #27

merged 5 commits into from
Nov 25, 2019

Conversation

FDiskas
Copy link
Contributor

@FDiskas FDiskas commented Oct 10, 2019

Added npm ci task and respect yarn

Closes #26

@FDiskas
Update tasks.js
dcb0174 
Added `npm ci` task and respect yarn
@FDiskas
Update README.md
89bde50 
Updated readme
@FDiskas
Update index.js
28bce2b 
Add npm install task
@FDiskas
Update README.md
f033a99
@FDiskas
Update tasks.js
d50880a
@pmadruga
Copy link
Owner

Thanks! I'll take a look as soon as possible.

@FDiskas
Copy link
Contributor Author

FDiskas commented Oct 14, 2019

Keep in mind that I did not test it.
Thanks

@FDiskas
Copy link
Contributor Author

FDiskas commented Oct 24, 2019 •
edited
Loading

Any news?
Let me win some T-shirts :D

@pmadruga
Copy link
Owner

I haven't had the time to test it yet. Life is a bit in the way right now but will do my best to review this quickly.

mikehardy
mikehardy approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmadruga I came here to check on #28 and saw another one that hadn't been reviewed, just wanted to say this seems sensible to me

@pmadruga pmadruga merged commit c4df2d3 into pmadruga:master Nov 25, 2019
@FDiskas FDiskas deleted the patch-1 branch November 25, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@pmadruga pmadruga pmadruga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: yarn install (if yarn is installed)
3 participants
@FDiskas @pmadruga @mikehardy