Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with "unique" orders #54

Closed
theimo1221 opened this issue Feb 20, 2018 · 1 comment
Closed

Problem with "unique" orders #54

theimo1221 opened this issue Feb 20, 2018 · 1 comment

Comments

@theimo1221
Copy link
Contributor

Look at this comparision:
image

In the bottom current code, wich groups by price and then filters all less than 1% of Volume in Range.
In the top I first filter all orders < 1% of Volume in Range and then group by prize.

This results in much better data. e.g. the sell order at 0.083 (yellow) is 1 50 ETH order plus 5 additional orders (summed up to 6 ETH).
Top graph warns about a whale. Bottom graph say "Nah, it´s okay, there are 6 unique orders"

Wrote it as an issue to post picture.

theimo1221 added a commit to theimo1221/eth_python_tracker that referenced this issue Feb 20, 2018
Before I forget, I additionally added desired port to global variables.

The rest is explained in pmaji#54
pmaji added a commit that referenced this issue Feb 21, 2018
Fixed a logic failure in calculation for #54
@pmaji
Copy link
Owner

pmaji commented Feb 21, 2018

Closing this because I merged the PR that fixed the filter order problem that lead to this. Great catch @theimo1221 .

@pmaji pmaji closed this as completed Feb 21, 2018
@theimo1221 theimo1221 mentioned this issue Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants