I think I finally got one lol

[jargoman]

RippleBinarySerializer method readAmount line 129
You forgot to add the sign to BigDecimal fractionalValue
BigInteger biMagnitude = BigInteger.valueOf(longMagnitude);
should be...
BigInteger biMagnitude = BigInteger.valueOf(longMagnitude * sign);

or if you'd rather
if (sign<0) {
fractionalValue.negate();
}

[pmarches]

Good catch!

The sign was used for XRP values, but not for issued currencies. I made the
change and pushed it to github.

Thanks!

On Mon, Feb 10, 2014 at 12:28 AM, jargoman notifications@github.com wrote:

RippleBinarySerializer method readAmount line 129
You forgot to add the sign to BigDecimal fractionalValue
BigInteger biMagnitude = BigInteger.valueOf(longMagnitude);
should be...
BigInteger biMagnitude = BigInteger.valueOf(longMagnitude * sign);

or if you'd rather
if (sign<0) {
fractionalValue.negate();
}

Reply to this email directly or view it on GitHubhttps://github.com//issues/19
.

[nybbs2003]

should't this be closed as it is solved?

[pmarches]

Indeed, I thought I had.