-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External links shouldn't have duplicate detection... #16
Comments
It doesn't depend on the link. ... The plugin compares the browser URL. If it is exactly the same 2 times, imo there should be a warning. If you edit tab 1, then tab2 ... you'll have different version. So saving the stuff to the same xx.html file will cause data loss. If you don't have the same URL ... there may be a bug. ... |
Can you give an example? |
Let's say I have a TW with a link to a pdf. [[file:img/test.pdf]] First time I click the link, it opens the pdf in a new tab as expected. Then I go back to the wiki and click the link again.... it opens the pdf in a second tab. Also as expected. But it throws up your big red warning box. That should not happen, unless it's a TW that's opened twice. Is that explained better? I could make a sample TW I guess, but I'm not sure that would help explain. |
Ah. OK I'll need to check this. ... deffinitely unwanted behaviour. ... But I'm not sure if there's an easy fix. ... |
@furicle ... please check out the latest version: https://addons.mozilla.org/en-US/firefox/addon/file-backups/ I did wanted to sign it and distribute it as a beta with github, but it seems I can't have both. listed and self-signed :/ |
Looking good! Can't duplicate the issue now, using 0.3.5 (FF 58.02 x64 on Win10) |
If you have an external link in TW
e.g. [ext[TWC users|file:///c/users/santa/documents/naughty/]]
Clicking once opens the location in another tab as expected.
Clicking that link a second time (or from a different TW) triggers the duplicate warning.
I don't think that's appropriate when the link is to something external?
The text was updated successfully, but these errors were encountered: