Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.4.0 extension stops working #34

Open
pmario opened this issue Mar 20, 2020 · 33 comments
Open

V0.4.0 extension stops working #34

pmario opened this issue Mar 20, 2020 · 33 comments
Labels
bug

Comments

@pmario
Copy link
Owner

pmario commented Mar 20, 2020

Have fun!
mario

PS: If you use it: Support it!
@jeroppi
Copy link

jeroppi commented Jun 29, 2020

Dear Mario

Thank you very much for creating File-Backups for Tiddlywiki.

I am having this weird issue: File-backups (0.4.0) works perfectly for a while, but then all of a sudden it stops saving the backups.
If I am lucky, at some point in time it will work again, (but just for a short time: maybe for a day or for some hours) and after a while it breaks again and seems to stop working for good.

I cannot recognize any cause nor any patterns. The behavior seems erratic to me.

Windows 10 (update 2004), Firefox 77.0.1 (64-bit).

Firefox download options settings (please see screenshot):

I have created a folder (other than Windows' "Downloads") for Firefox downloads, because I want to have my wikis and backups saved on their own partition of my Notebook's SSD. Firefox seems to be OK with that: "File-Backups" works like a charm, saving the wikis, creating the backup folders and populating these with the backups. (Except when it stops working.)

I have Firefox set up to "always ask where to save files", but when "File-Backups" is working fine, the wikis are correctly saved and backed up without Firefox asking me anything.

At some point in time I then notice that "File-Backups" has stopped working because Firefox starts to ask me where to save the wiki. I then browse to the usual location, but Firefox says that the file already exists, and my only option is to overwrite it. And no backups are created in the backup folders.

Is this a known issue?
Do you know if I can I do something to stop this issue?

Yours truly
Jeronimo Miniño

Firefox_download_options

@pmario
Copy link
Owner Author

pmario commented Jun 29, 2020

I have Firefox set up to "always ask where to save files", but when "File-Backups" is working fine, the wikis are correctly saved and backed up without Firefox asking me anything.

That's a configuration I didn't test. .. So I'll have to have a closer look here.

@pmario
Copy link
Owner Author

pmario commented Jun 29, 2020

Is your PC running 24/7 and FireFox open all the time?

@jeroppi
Copy link

jeroppi commented Jun 30, 2020 via email •
edited
Loading

@jeroppi
Copy link

jeroppi commented Jun 30, 2020 via email •
edited
Loading

@pmario
Copy link
Owner Author

pmario commented Jun 30, 2020

How big is your wiki in MByte?

@pmario
Copy link
Owner Author

pmario commented Jun 30, 2020

Do you edit several wikis at the same time? ... I'm asking, so I can "rebuild" a setting, that is similar to yours.

@pmario
Copy link
Owner Author

pmario commented Jun 30, 2020

So you use the "Always ask, where to save" as an indicator, when fb fails. right?

@pmario pmario changed the title V0.4.0 feedback V0.4.0 extension stops working Jun 30, 2020
@pmario
Copy link
Owner Author

pmario commented Jun 30, 2020

@jerojerojeroppi ... I did rename the issue and tagged it as bug

@jeroppi
Copy link

jeroppi commented Jun 30, 2020 via email •
edited
Loading

@jeroppi
Copy link

jeroppi commented Jun 30, 2020 via email

@jeroppi
Copy link

jeroppi commented Jun 30, 2020 via email •
edited
Loading

@pmario
Copy link
Owner Author

pmario commented Jul 5, 2020

Hi, ... I did create an 18MByte TW and have it opened all the time. From time to time I'm switching to the tab and make some changes. I did create the exact same directory structure you used in your screenshot.

The only differences are, that FF has updated in the meantime to 78.0.1 and my Windows is: Pro 10 (1903)

I do use more FF plugins. ...

I couldn't replicate the problem till now. ... So we will have to wait and see.

In the meantime you'll have to have a close look at you "indicator" ... the browser download dialog. ...

What I'd like to know, if file-backup stopps working. ... Does it help if you do a "Tab reload" for the wiki with F5. ...

BUT be sure you did save your changes!!!

@jeroppi
Copy link

jeroppi commented Jul 7, 2020 via email

@jeroppi
Copy link

jeroppi commented Jul 9, 2020 via email •
edited
Loading

@jeroppi
Copy link

jeroppi commented Jul 9, 2020 •
edited
Loading

Oh, you could not replicate the issue... Merkwürdig!

If you think it's a good idea, I can send you a copy of one of my wikis (after deleting sensible data). So we could see if the issue is particular to my wikis.

As soon as I can take some time, I will see if I can replicate the issue on my second PC. I will give feedback.

FWIW:

The PC I am using now is a Huawei Matebook Pro model 2018 I bought new 3 months ago. It seems to run full ok, I have not had any issues whatsoever. i7-8550u, 16GB RAM, dedicated nvidia graphics.
Windows 10 Home, as of today: version 2004, OS Build 19041.329

Wired connections:

  • a second screen (HDMI)
  • high speed internet (ethernet)

Wireless connections:

  • wifi (same network as the wired one),

Periferals:

  • bluetooth: mouse, headset
  • old smartphone used as a webcam, connected through wifi

I am also using "Mouse Without Borders" to share the mouse, the keyboard and the clipboard with a second (tablet-)PC through WiFi.

@pmario
Copy link
Owner Author

pmario commented Jul 10, 2020

... OK .. I saw a weakness. ... If you install the AddOn AND the wiki is already open, the AddOn isn't active for already open tabs. .. So they have to be refreshed. ... I'm pretty sure, that's what you saw, with the new setup.

@pmario pmario mentioned this issue Jul 10, 2020
Open
@pmario
Copy link
Owner Author

pmario commented Jul 10, 2020

I did create a new issue #37. So it won't be lost.

@jeroppi
Copy link

jeroppi commented Jul 10, 2020

Hi!

Thank you for your kind message and for your continuous efforts in improving fb. Last time I wrote that at some point I "loaded" a wiki. Sorry: what I meant with "loaded" is that I "opened" the wiki in a tab. I thought I did it after installing the extension, but I'm not 100% sure. Chances are you're right.

I had to spend a day working on something unrelated to the wikis, but in a couple of hours I will start editing wikis again. I will send you feedback.

@jeroppi
Copy link

jeroppi commented Jul 16, 2020 •
edited
Loading

Hi.
Today (at last!) I have been able to identify one thing that consistently triggers the behavior of FilesBackup stopping to save a wiki correctly in my PC:

First thing, I must state that I never open a wiki from Firefox's menu "Open file". I ALWAYS open my wikis by going to the wikis' folder, right-clicking on the file's name and then clicking "open with" and "Firefox" in Windows Explorer's context menu.

Well, what I noticed today is that when Firefox is already open AND THEN I open a wiki, everything runs fine: The wiki opens in a Firefox tab, and everytime I edit a tiddler or I click on the save icon, the wiki seems to be saved/backed up properly.

BUT if I open a wiki (from Windows Explorer's context menu, as I always do) when Firefox is NOT YET open, then Firefox opens with the wiki in a tab, but the first time I try to save the wiki, it will NOT be saved/backed-up properly. What happens is that my "indicator" kicks in (i.e. the browser download dialog opens).

I am curious if you can replicate this.

From now on I intend to make sure Firefox is open before I open any wiki, so I can test if that was the only cause of the problem.

@jeroppi
Copy link

jeroppi commented Jul 16, 2020 •
edited
Loading

By the way, I always have Firefox set to "restore previous session" at the browser's startup.

I tried some more things:

Experiment 1.

  • uncheck the option "restore previous session" at browser's startup in settings.
  • this didn't seem to have any influence on the observed behavior.

Experiment 2.

  • Open Firefox
  • Open a wiki from Windows Explorer context menu ("Open with" "Firefox")
  • Close Firefox (without having closed the wiki's tab)
  • Reopen Firefox
  • Firefox restores the wiki's tab
  • Try to save the wiki... it saved OK.

Experiment 3.

  • Firefox is closed.
  • I Open a wiki from Windows Explorer context menu ("Open with" "Firefox")
  • Firefox opens with one tab. This tab contains the wiki.
  • Try to save the wiki... It failed: I got the download window.
  • I cancel the download window without having overwritten the wiki.
  • (I can repeat the former two steps any number of times)
  • Then I close Firefox (without having closed the wiki's tab)
  • Next I open Firefox
  • Firefox restores the wiki's tab
  • I try to save the wiki... Now the wiki was saved/backed up properly (and it kept saving/backing-up properly during the whole browser session).

Experiment 4:

  • First I do one of the two previous procedures, (1.) or (2.) (it will make no difference)
  • Then I close the browser again (without having closed the wiki's tab)
  • Then I go to the wikis' folder, right click on that same wiki and "Open with" "Firefox".
  • This time Firefox opens with the same wiki in two tabs. (I suppose that the first tab is the one restored from the previous session, and that the second tab contains the instance of the wiki which I just opened by right-clicking.)
  • As it opens, the browser shows the wiki in the second tab. There I try to save the wiki... and the saving fails: The browser download window opens instead.
  • I cancel that browser download window without overwriting the wiki
  • Then I go to the first window. There I get a big red warning about the wiki being open in another tab.
  • Not caring about the big red warning, I proceed to save the Wiki... IT SAVES OK.
  • I can jump back and forth, and get the same results every time: On the first tab (the one with the big red warning) the wiki saves OK everytime. But on the second tab the wiki cannot be saved/backed-up properly.

@pmario
Copy link
Owner Author

pmario commented Jul 17, 2020

Which FF version do you use?

@pmario
Copy link
Owner Author

pmario commented Jul 17, 2020

Forget the last post. I saw it in the OP

@pmario
Copy link
Owner Author

pmario commented Jul 17, 2020

As soon as the "red banner" is shown, the AddOn is active. The check, if several tabs contain the same wiki is done by the AddOn.

@pmario
Copy link
Owner Author

pmario commented Jul 17, 2020

Do you work with "FF Private Mode"?

@pmario
Copy link
Owner Author

pmario commented Jul 17, 2020

hmmm. ... I could replicate it 1 time, with a new VM after a restart. .... So there is an initialisation problem. ... I can't reproduce it reliably. ... But since you can, it has to be that way.

I'll have to have a closer look, how I can improve the init behaviour. ... It'll need some time. ...

I hope you have enough info, to avoid the problem ... But as said. I'll have a look, how I can improve it.

@jeroppi
Copy link

jeroppi commented Jul 17, 2020 via email

@jeroppi
Copy link

jeroppi commented Jul 17, 2020 via email

@jeroppi
Copy link

jeroppi commented Jul 17, 2020 via email

@jeroppi
Copy link

jeroppi commented Jul 17, 2020 •
edited
Loading

Thank you very much. Yes, I think now I can manage.

When I get to make tests on other computers, I will tell you the results.

I think my "Experiment 4." is likely to give you some hints on how the problem arises:
I can now reliably create the situation where I have the same wiki open in two browser tabs simultaneously: In one tab the addon is working fine, while at the same time, on the other tab the addon is not working. And I can reliably predict whether the addow will work in a tab or not, depending on the procedure I used to open the wiki in that tab. I will try to make a video capture of this. That might be clearer than my convoluted explanations (and my English! LOL).

@pmario
Copy link
Owner Author

pmario commented Jul 17, 2020

Your workflow is completely different to mine. In my setting I use FF as the default browser. So I only need a "double click" to open the wiki. ... So I never ever tested to open a wiki with "open with" from the explorer.

So I'm pretty sure, it's an init-problem. ... Once I do have an "universal init" set up right, the problem should be gone .... hopefully.

So it's not really necessary to create more test cases, that use up a lot of your time. .. I think I do have enough info.

@jeroppi
Copy link

jeroppi commented Jul 19, 2020

OK, I see, great! Thanks a lot!
Btw, one reason why I love this addon is because I find its backup scheme outstanding. Other solutions just create backup folders that grow and grow with no limit.

@pmario pmario mentioned this issue Jul 20, 2020
Open
@Skeeve
Copy link

Skeeve commented Jul 27, 2020

Hi Mario.
Today I wanted to start a new TW for a colleague I am the vacation stand-in for.

The new-empty wiki didn't save and so I landed here.

First the environment:
MacBookPro 10.14.6
FireFox 78.0.2 (64-bit) (Default Browser)
File Backups 0.4.0
Mac uptime 7 days

When I noticed the new TW didn't save, I opened my old TW (via Bookmark) and it didn't save either.

I opened a TW via dragging the file to an empty tab - it didn't save

I read the bug info found here and closed FF.

I then opened by double-clicking my new empty TW. I could save. (Hooray) ;)

I then opened my old TW via Bookmark and could save that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pmario @Skeeve @jeroppi