Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NestJS examples #84

Closed
wants to merge 3 commits into from
Closed

Added NestJS examples #84

wants to merge 3 commits into from

Conversation

thachp
Copy link

@thachp thachp commented Dec 8, 2020

This is a work in progress.

@pmb0
Copy link
Owner

pmb0 commented Dec 11, 2020

Thank you for this MR, but I cannot accept it in this form.

  • The e2e tests are now failing because the Express sample app is now in a different location.
  • another package.json with own dependencies was introduced
  • if already a NestJS example is introduced, the existing Express example should not be called example, but express.
  • The coding conventions of this project (eslint, editorconfig, etc) were not followed.
  • ...

I will provide a complete running NestJS example (and maybe a NestJS TSX module) soon.

@thachp
Copy link
Author

thachp commented Dec 13, 2020

@pmb0 Sound good! Thanks for looking into this.

@thachp thachp closed this Dec 13, 2020
@pmb0
Copy link
Owner

pmb0 commented Dec 13, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants