Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current desktop number in the tray bar #50

Closed
cesera opened this issue Mar 11, 2020 · 10 comments
Closed

Show current desktop number in the tray bar #50

cesera opened this issue Mar 11, 2020 · 10 comments

Comments

@cesera
Copy link

cesera commented Mar 11, 2020

Thank you so much for this script. This has been the one thing that has been bothering me with the Windows virtual desktops, and now they are finally workable.

I don't know if you do feature requests, but just in case: Would it be possible to show the number of the current virtual desktop on the system tray icon? That way I always know what desktop I'm on.

@Elijas Elijas linked a pull request Mar 23, 2020 that will close this issue
@Elijas
Copy link
Collaborator

Elijas commented Mar 23, 2020

Hi, We're glad you've found the script useful!

You can check out an alternative to our script which has dynamic tray icons that you're looking for, and other additional features: sdias/win-10-virtual-desktop-enhancer.

Also, I've worked on a pull request #34 before, on this exact feature that you're asking for. If I remember, the implementation didn't work in as stable and fast manner as without having the tray icons, so I decided to scrap it at the time.

If someone would want to implement this, there are plenty of code examples and the icons themselves in sdias/win-10-virtual-desktop-enhancer and pull request #34 .

@Elijas Elijas changed the title Feature Request Show current desktop number in the tray bar Mar 23, 2020
@cesera
Copy link
Author

cesera commented Mar 24, 2020 via email

@Elijas
Copy link
Collaborator

Elijas commented Mar 24, 2020

Most likely it stopped working due to the DLL failing compatibility with the newer version of Windows. You might be able to continue using the other script if you replace

@cesera
Copy link
Author

cesera commented Mar 24, 2020 via email

@Elijas
Copy link
Collaborator

Elijas commented Mar 24, 2020

No problem! Feel free to support the project if you've found it useful.

@Elijas Elijas closed this as completed Mar 24, 2020
@adamency
Copy link

adamency commented Sep 23, 2021

What is the current status of adding this feature to the project ? Especially considering the recommended alternative project is unmaintained since 2018.

@Elijas
Copy link
Collaborator

Elijas commented Sep 23, 2021

It has been a while, but AFAIR It's not that hard to add this feature if users always changed their desktops using the app alone. You'd just need to add "Change tray icon" command after the "Change Desktop" command in the code (I did this before: #34).

It's more difficult when detection is needed for users switching desktops through Windows UI, etc. I started working on it, but bug corner cases kept popping up, so I didn't release the feature, because it was somewhat buggy, but did not have the resources to work on it further either. I believe there was some slight but noticeable impact on performance, but I can't remember exactly.

Status? If someone made a robustly working status icon changing functionality without noticeable impact on performance, would be happy to review and include it to the project. I, myself, unfortunately don't work on new features for this project anymore.

@adamency
Copy link

adamency commented Oct 6, 2021

Alright, thanks for the answer.

Just wanted to let other users of this project aware of this little repo written in C# that implements this feature in an atomic way, and perfectly works independently and concurrently to this project: https://github.com/zgdump/windows-virtualdesktopindicator

Works with Windows UI and through this application.

@Elijas
Copy link
Collaborator

Elijas commented Oct 6, 2021

@adamency This is awesome, I'll add it to the README.md

@whitenoisedev
Copy link

This util works with Win11 22H2. https://github.com/dankrusi/WindowsVirtualDesktopHelper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants