Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug a flaky test on Windows #564

Merged
merged 3 commits into from Sep 11, 2023
Merged

debug a flaky test on Windows #564

merged 3 commits into from Sep 11, 2023

Conversation

pmcelhaney
Copy link
Owner

@pmcelhaney pmcelhaney commented Sep 11, 2023

The "transpiler... discovers a new file and transpiles it" test was failing on all PRs. Of course when I try to debug it passes. Let's just merge this and see what happens with the other PRs.

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

⚠️ No Changeset found

Latest commit: ea521b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2023

Pull Request Test Coverage Report for Build 6152803380

  • 5 of 9 (55.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 87.755%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/server/transpiler.ts 5 9 55.56%
Totals Coverage Status
Change from base Build 6110871712: -0.08%
Covered Lines: 2409
Relevant Lines: 2776

💛 - Coveralls

@pmcelhaney pmcelhaney merged commit 80246ab into main Sep 11, 2023
7 checks passed
@pmcelhaney pmcelhaney deleted the flaky-test-on-windows branch September 11, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants