Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edge case where a file shadows a directory #661

Merged
merged 15 commits into from Nov 24, 2023
Merged

Conversation

pmcelhaney
Copy link
Owner

Say you have a directory structure like this:

- a
  - b.js
- a.js

The path for "a/b" would be handled by a.js instead of a/b.js. To fix, I completely rewrote the code to load and find modules and put it in a new class called ModuleTree.

Copy link

changeset-bot bot commented Nov 24, 2023

🦋 Changeset detected

Latest commit: 7884555

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
counterfact Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 6984412802

  • 231 of 245 (94.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 83.129%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/server/module-tree.ts 220 234 94.02%
Totals Coverage Status
Change from base Build 6978270104: 0.5%
Covered Lines: 2473
Relevant Lines: 3040

💛 - Coveralls

@pmcelhaney pmcelhaney merged commit 83073c0 into main Nov 24, 2023
8 checks passed
@pmcelhaney pmcelhaney deleted the fix-cutofftime-bug branch November 24, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants