New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rate_limit task setting will discard tasks if exceeded #1
Comments
This is definitely not the behavior I intended. This sounds like a celery bug. Do you know if it's reported, or fixed in a later version or something? I'm fairly positive that this is not how it's supposed to work. |
I don't think it's a bug. The documentation is a little unclear for rate_limit (http://docs.celeryproject.org/en/latest/userguide/tasks.html?highlight=rate_limit#Task.rate_limit), but I found this thread on StackOverflow: http://stackoverflow.com/questions/7541931/how-is-rate-limit-enforced-in-celery. I haven't been able to dig into the code, and also don't understand how the scheduler works yet. |
I talked to ask (celery author) on IRC and he said that this is absolutely not the case. The person on stack overflow is very wrong. Ask also added that the token bucket algorithm that the person mentioned doesn't necessarily mean that items are discarded. |
Thanks so much for looking into this! I see the correct response now on Stack Overflow. |
* APD-360 - [BE] upgrade to celery 4.x * Update README * Correct Python in tox and readme * Correct Python in tox and readme * Remove Python 3.3 from tox * Add tox-travis
I know it's not a required setting, but it appears as though celery will just discard the tasks if this rate_limit is exceeded. In other words, if this is set, and you're exceeded the rate_limit sending emails, the emails will just get discarded which is probably not the behavior you intended.
Please correct me if I'm wrong.
The text was updated successfully, but these errors were encountered: