Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old PMD icons #82

Closed
adangel opened this issue Jan 18, 2019 · 1 comment
Closed

Support old PMD icons #82

adangel opened this issue Jan 18, 2019 · 1 comment
Assignees
Milestone

Comments

@adangel
Copy link
Member

adangel commented Jan 18, 2019

There should be a configuration option to use the old icons instead of the shapes.

grafik

See also https://sourceforge.net/p/pmd/bugs/1151/

At the same time, the logic to change the shapes should be redone: Currently the icon files are replaced in the installation path of the plugin (which is impossible if this is a readonly location like in multiuser installs). The custom icons should be stored in the workspace state location.

When changing the icons, they should be used universally, also for the decorators. See also https://sourceforge.net/p/pmd/bugs/1212/.

@adangel
Copy link
Member Author

adangel commented Jun 28, 2019

@adangel adangel self-assigned this Jun 28, 2019
adangel added a commit to adangel/pmd-eclipse-plugin that referenced this issue Jun 28, 2019
@adangel adangel added this to the 4.5.0 milestone Jun 29, 2019
@adangel adangel added the has:pr label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant