Support Eclipse SimRel 2018-09 #61
Conversation
jftsunami
commented
Sep 21, 2018
jftsunami
commented
- Remove org.apache.commons.io and org.apache.log4j from exports
- Added above to dependencies for test project
- Modification to test due to EOL conversions done by Git on Windows
* Remove org.apache.commons.io and org.apache.log4j from exports * Added above to dependencies for test project * Modification to test due to EOL conversions done by Git on Windows
There was a problem hiding this comment.
Thanks for the PR! It looks good, not exporting log4j is ok. I guess, long term, pmd-eclipse-plugin should not use log4j at all.
I've changed the title of your PR, since it actually solves the problem with Eclipse SimRel 2018-09. I didn't run into the problem with log4j with Photon...
|
I assume the Eclipse runtime has some sort of logging plug-in that can be depended on, but would just changing everything to log to slf4j be sufficient? |
|
I didn't change the logging at all in the plugin. So, pmd-eclipse-plugin still uses internally log4j. The missing export would only be a problem for other plugins, that use log4j from pmd-eclipse-plugin without shipping their own version... which probably is anyway not the case. The pmd-eclipse-plugin currently logs sometimes using log4j and sometimes using the eclipse platform (see https://wiki.eclipse.org/FAQ_How_do_I_use_the_platform_logging_facility%3F), which long-term should be resolved to be eclipse platform logging only. |
|
Got it (and thanks for that link) |
