Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No annotations created under Windows #51

Closed
adangel opened this issue Feb 10, 2022 · 1 comment · Fixed by #59
Closed

No annotations created under Windows #51

adangel opened this issue Feb 10, 2022 · 1 comment · Fixed by #59
Labels
bug Something isn't working
Milestone
v1.2.1

Comments

@adangel
Copy link
Member

adangel commented Feb 10, 2022

If the action is executed under Windows, then no code annotations are created. This is probably because of platform specific file paths (e.g. src/main/java vs. src\main\java) and github can't map this to the files.
@adangel adangel added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 10, 2022
@adangel adangel removed help wanted Extra attention is needed good first issue Good for newcomers labels Feb 19, 2022
@adangel
Copy link
Member Author

adangel commented Feb 19, 2022

See also pmd/pmd#3798

@adangel adangel added this to the next milestone Feb 19, 2022
@adangel adangel mentioned this issue Feb 19, 2022
Merged
adangel added a commit that referenced this issue Feb 19, 2022
@adangel
Merge pull request #59 from adangel:issue-51-annotations-windows
c087fa6 
Fixes #51 Convert Windows paths #59
@adangel adangel mentioned this issue Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #51 Convert Windows paths adangel/pmd-github-action
1 participant
@adangel